diff options
| author | Lucas Trzesniewski <lucas.trzesniewski@gmail.com> | 2025-10-31 19:36:06 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-10-31 11:36:06 -0700 |
| commit | d3bcf9aba578c08a619e5788b40077521f9bde5c (patch) | |
| tree | 69184a1c0ce6ed6ba9337d3b9cbaee303fc01c47 /.github/workflows/rust.yml | |
| parent | chore: adjust update wording (#2974) (diff) | |
| download | atuin-d3bcf9aba578c08a619e5788b40077521f9bde5c.zip | |
ci: add Windows builds, second try (#2966)
Hi @ellie, I don't want to be a burden, but I'd like to ask if you could
please reconsider adding Windows builds now that PowerShell support is
merged (#2543). 😇
Most people use PowerShell on Windows, so they'd need an artifact in the
future releases in order to use it. Otherwise, they'd have to install
Rust and compile it themselves, which is not user-friendly.
I'd like to point out that I didn't have issues with building Atuin on
Windows when I was rebasing the PowerShell PR (except some initial stuff
like `#[cfg]` or a few warnings which were fixed in #2856), so I don't
expect this to introduce many problems.
This is essentially an updated version of #2714.
## Checks
- [x] I am happy for maintainers to push small adjustments to this PR,
to speed up the review cycle
- [x] I have checked that there are no existing pull requests for the
same thing
Diffstat (limited to '.github/workflows/rust.yml')
| -rw-r--r-- | .github/workflows/rust.yml | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index b65f9a81..5498ed7e 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -17,7 +17,7 @@ jobs: build: strategy: matrix: - os: [ubuntu-latest, macos-14] + os: [ubuntu-latest, macos-14, windows-latest] runs-on: ${{ matrix.os }} steps: @@ -88,7 +88,7 @@ jobs: unit-test: strategy: matrix: - os: [ubuntu-latest, macos-14] + os: [ubuntu-latest, macos-14, windows-latest] runs-on: ${{ matrix.os }} steps: @@ -118,7 +118,7 @@ jobs: check: strategy: matrix: - os: [ubuntu-latest, macos-14] + os: [ubuntu-latest, macos-14, windows-latest] runs-on: ${{ matrix.os }} steps: |