aboutsummaryrefslogtreecommitdiffstats
path: root/.github/workflows
diff options
context:
space:
mode:
authorLucas Trzesniewski <lucas.trzesniewski@gmail.com>2025-10-31 19:36:06 +0100
committerGitHub <noreply@github.com>2025-10-31 11:36:06 -0700
commitd3bcf9aba578c08a619e5788b40077521f9bde5c (patch)
tree69184a1c0ce6ed6ba9337d3b9cbaee303fc01c47 /.github/workflows
parentchore: adjust update wording (#2974) (diff)
downloadatuin-d3bcf9aba578c08a619e5788b40077521f9bde5c.zip
ci: add Windows builds, second try (#2966)
Hi @ellie, I don't want to be a burden, but I'd like to ask if you could please reconsider adding Windows builds now that PowerShell support is merged (#2543). 😇 Most people use PowerShell on Windows, so they'd need an artifact in the future releases in order to use it. Otherwise, they'd have to install Rust and compile it themselves, which is not user-friendly. I'd like to point out that I didn't have issues with building Atuin on Windows when I was rebasing the PowerShell PR (except some initial stuff like `#[cfg]` or a few warnings which were fixed in #2856), so I don't expect this to introduce many problems. This is essentially an updated version of #2714. ## Checks - [x] I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle - [x] I have checked that there are no existing pull requests for the same thing
Diffstat (limited to '.github/workflows')
-rw-r--r--.github/workflows/release.yml8
-rw-r--r--.github/workflows/rust.yml6
2 files changed, 10 insertions, 4 deletions
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index ca92fbd3..ce68d19e 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -1,5 +1,6 @@
# This file was autogenerated by dist: https://github.com/astral-sh/cargo-dist
#
+# Copyright 2022-2024, axodotdev
# Copyright 2025 Astral Software Inc.
# SPDX-License-Identifier: MIT or Apache-2.0
#
@@ -60,12 +61,13 @@ jobs:
steps:
- uses: actions/checkout@v4
with:
+ persist-credentials: false
submodules: recursive
- name: Install dist
# we specify bash to get pipefail; it guards against the `curl` command
# failing. otherwise `sh` won't catch that `curl` returned non-0
shell: bash
- run: "curl --proto '=https' --tlsv1.2 -LsSf https://github.com/astral-sh/cargo-dist/releases/download/v0.28.3/cargo-dist-installer.sh | sh"
+ run: "curl --proto '=https' --tlsv1.2 -LsSf https://github.com/astral-sh/cargo-dist/releases/download/v0.28.7/cargo-dist-installer.sh | sh"
- name: Cache dist
uses: actions/upload-artifact@v4
with:
@@ -119,6 +121,7 @@ jobs:
git config --global core.longpaths true
- uses: actions/checkout@v4
with:
+ persist-credentials: false
submodules: recursive
- name: Install Rust non-interactively if not already installed
if: ${{ matrix.container }}
@@ -181,6 +184,7 @@ jobs:
steps:
- uses: actions/checkout@v4
with:
+ persist-credentials: false
submodules: recursive
- name: Install cached dist
uses: actions/download-artifact@v4
@@ -230,6 +234,7 @@ jobs:
steps:
- uses: actions/checkout@v4
with:
+ persist-credentials: false
submodules: recursive
- name: Install cached dist
uses: actions/download-artifact@v4
@@ -294,4 +299,5 @@ jobs:
steps:
- uses: actions/checkout@v4
with:
+ persist-credentials: false
submodules: recursive
diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml
index b65f9a81..5498ed7e 100644
--- a/.github/workflows/rust.yml
+++ b/.github/workflows/rust.yml
@@ -17,7 +17,7 @@ jobs:
build:
strategy:
matrix:
- os: [ubuntu-latest, macos-14]
+ os: [ubuntu-latest, macos-14, windows-latest]
runs-on: ${{ matrix.os }}
steps:
@@ -88,7 +88,7 @@ jobs:
unit-test:
strategy:
matrix:
- os: [ubuntu-latest, macos-14]
+ os: [ubuntu-latest, macos-14, windows-latest]
runs-on: ${{ matrix.os }}
steps:
@@ -118,7 +118,7 @@ jobs:
check:
strategy:
matrix:
- os: [ubuntu-latest, macos-14]
+ os: [ubuntu-latest, macos-14, windows-latest]
runs-on: ${{ matrix.os }}
steps: