diff options
| author | Lucas Trzesniewski <lucas.trzesniewski@gmail.com> | 2025-10-31 19:36:06 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-10-31 11:36:06 -0700 |
| commit | d3bcf9aba578c08a619e5788b40077521f9bde5c (patch) | |
| tree | 69184a1c0ce6ed6ba9337d3b9cbaee303fc01c47 /.github/workflows/release.yml | |
| parent | chore: adjust update wording (#2974) (diff) | |
| download | atuin-d3bcf9aba578c08a619e5788b40077521f9bde5c.zip | |
ci: add Windows builds, second try (#2966)
Hi @ellie, I don't want to be a burden, but I'd like to ask if you could
please reconsider adding Windows builds now that PowerShell support is
merged (#2543). 😇
Most people use PowerShell on Windows, so they'd need an artifact in the
future releases in order to use it. Otherwise, they'd have to install
Rust and compile it themselves, which is not user-friendly.
I'd like to point out that I didn't have issues with building Atuin on
Windows when I was rebasing the PowerShell PR (except some initial stuff
like `#[cfg]` or a few warnings which were fixed in #2856), so I don't
expect this to introduce many problems.
This is essentially an updated version of #2714.
## Checks
- [x] I am happy for maintainers to push small adjustments to this PR,
to speed up the review cycle
- [x] I have checked that there are no existing pull requests for the
same thing
Diffstat (limited to '.github/workflows/release.yml')
| -rw-r--r-- | .github/workflows/release.yml | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index ca92fbd3..ce68d19e 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -1,5 +1,6 @@ # This file was autogenerated by dist: https://github.com/astral-sh/cargo-dist # +# Copyright 2022-2024, axodotdev # Copyright 2025 Astral Software Inc. # SPDX-License-Identifier: MIT or Apache-2.0 # @@ -60,12 +61,13 @@ jobs: steps: - uses: actions/checkout@v4 with: + persist-credentials: false submodules: recursive - name: Install dist # we specify bash to get pipefail; it guards against the `curl` command # failing. otherwise `sh` won't catch that `curl` returned non-0 shell: bash - run: "curl --proto '=https' --tlsv1.2 -LsSf https://github.com/astral-sh/cargo-dist/releases/download/v0.28.3/cargo-dist-installer.sh | sh" + run: "curl --proto '=https' --tlsv1.2 -LsSf https://github.com/astral-sh/cargo-dist/releases/download/v0.28.7/cargo-dist-installer.sh | sh" - name: Cache dist uses: actions/upload-artifact@v4 with: @@ -119,6 +121,7 @@ jobs: git config --global core.longpaths true - uses: actions/checkout@v4 with: + persist-credentials: false submodules: recursive - name: Install Rust non-interactively if not already installed if: ${{ matrix.container }} @@ -181,6 +184,7 @@ jobs: steps: - uses: actions/checkout@v4 with: + persist-credentials: false submodules: recursive - name: Install cached dist uses: actions/download-artifact@v4 @@ -230,6 +234,7 @@ jobs: steps: - uses: actions/checkout@v4 with: + persist-credentials: false submodules: recursive - name: Install cached dist uses: actions/download-artifact@v4 @@ -294,4 +299,5 @@ jobs: steps: - uses: actions/checkout@v4 with: + persist-credentials: false submodules: recursive |