Cleaning code

10 files changed, 32 insertions, 243 deletions

diff --git a/src/pages/options/general/general.html b/src/pages/options/general/general.html
index 3a7e8cf2..92cd48c5 100644
--- a/src/pages/options/general/general.html
+++ b/src/pages/options/general/general.html
@@ -38,65 +38,6 @@
         <span>Update Instances</span>
       </a>
     </div>
-    <!-- <hr> -->
-    <!-- <section class="settings-block">
-      <p data-localise="__MSG_exceptionsDescriptionP1__">
-        Enter a URL or Regular Expression to be excluded from redirects.
-      </p>
-      <p data-localise="__MSG_exceptionsDescriptionP2__">
-        All requests for or initiating from a URL that matches your exception
-        will be excluded from redirects.
-      </p>
-      <p data-localise="__MSG_exceptionsDescriptionP3__">
-        Note - Supports JavaScript regular expressions, excluding the
-        enclosing forward slashes.
-      </p>
-    </section>
-    <section class="settings-block">
-      <table class="exceptions option">
-        <tbody>
-          <tr>
-            <td>
-              <h1 data-localise="__MSG_addException__">Add Exception</h1>
-            </td>
-          </tr>
-          <tr>
-            <td>
-              <input id="new-exceptions-item" type="text" placeholder="URL or RegExp" />
-            </td>
-            <td>
-              <input type="radio" id="url" name="type" value="URL" checked />
-              <label class="radio" for="url">URL</label>
-              <input type="radio" id="regExp" name="type" value="RegExp" />
-              <label class="radio" for="regExp">RegExp</label>
-            </td>
-            <td>
-              <button id="add-to-exceptions">
-                <svg xmlns="http://www.w3.org/2000/svg" width="512" height="512" viewBox="0 0 512 512">
-                  <line x1="256" y1="112" x2="256" y2="400" style="
-                        fill: none;
-                        stroke: #fff;
-                        stroke-linecap: round;
-                        stroke-linejoin: round;
-                        stroke-width: 32px;
-                      " />
-                  <line x1="400" y1="256" x2="112" y2="256" style="
-                        fill: none;
-                        stroke: #fff;
-                        stroke-linecap: round;
-                        stroke-linejoin: round;
-                        stroke-width: 32px;
-                      " />
-                </svg>
-              </button>
-            </td>
-          </tr>
-        </tbody>
-      </table>
-    </section>
-    <ul id="exceptions-items"></ul>
-  </section> -->
-
 
   <script type="module" src="../init.js"></script>
   <script type="module" src="./general.js"></script>
diff --git a/src/pages/options/general/general.js b/src/pages/options/general/general.js
index 23c739aa..17b7a843 100644
--- a/src/pages/options/general/general.js
+++ b/src/pages/options/general/general.js
@@ -47,31 +47,6 @@ browser.storage.sync.get(
   }
 );
 
-// function addToExceptions() {
-//   const input = document.getElementById("new-exceptions-item");
-//   const type = document.querySelector('input[name="type"]:checked').value;
-//   if (input.value) {
-//     try {
-//       let value = input.value;
-//       new RegExp(input.value);
-//       if (type === "URL")
-//         value = value.replace(/[-\/\\^$*+?.()|[\]{}]/g, "\\$&");
-
-//       exceptions.push(value);
-//       browser.storage.sync.set({
-//         exceptions: exceptions,
-//       });
-//       prependExceptionsItem(value, exceptions.indexOf(value));
-//       input.value = "";
-//     } catch (error) {
-//       input.setCustomValidity("Invalid RegExp");
-//     }
-//   } else {
-//     input.setCustomValidity("Invalid RegExp");
-//   }
-// }
-// document.getElementById("add-to-exceptions").addEventListener("click", addToExceptions);
-
 themeElement.addEventListener("change", (event) => {
   const value = event.target.options[theme.selectedIndex].value;
   switch (value) {
diff --git a/src/pages/options/instagram/instagram.html b/src/pages/options/instagram/instagram.html
index 1f09cab7..98e296f8 100644
--- a/src/pages/options/instagram/instagram.html
+++ b/src/pages/options/instagram/instagram.html
@@ -28,22 +28,6 @@
             <h4>Enable</h4>
             <input id="disable-bibliogram" type="checkbox" checked />
         </div>
-        <!-- <div class="some-block option-block">
-            <h4>Instance</h4>
-            <div class="autocomplete">
-                <input id="bibliogram-instance" type="url" data-localise-placeholder="__MSG_randomInstancePlaceholder__"
-                    placeholder="Random instance (none selected)" />
-            </div>
-        </div> -->
-
-        <!-- <section class="settings-block">
-            <h4>Instance List</h4>
-            <div class="random-pool">
-                <textarea id="bibliogram-random-pool" name="bibliogram-random-pool" type="text"></textarea>
-                <ul id="bibliogram-random-pool-list"></ul>
-            </div>
-        </section> -->
-
 
     </section>
     <script type="module" src="../init.js"></script>
diff --git a/src/pages/options/medium/medium.html b/src/pages/options/medium/medium.html
index abf149c0..1c978d82 100644
--- a/src/pages/options/medium/medium.html
+++ b/src/pages/options/medium/medium.html
@@ -28,21 +28,6 @@
             <h4>Enable</h4>
             <input id="disable-scribe" type="checkbox" checked />
         </div>
-        <!-- <div class="some-block option-block">
-            <h4>Instance</h4>
-            <div class="autocomplete">
-                <input id="scribe-instance" type="url" name="scribe-instance"
-                    data-localise-placeholder="__MSG_randomInstancePlaceholder__"
-                    placeholder="Random instance (none selected)" />
-            </div>
-        </div>
-        <section class="settings-block">
-            <h4>Instance List</h4>
-            <div class="random-pool">
-                <textarea id="scribe-random-pool" type="text"></textarea>
-                <ul id="scribe-random-pool-list"></ul>
-            </div>
-        </section> -->
     </section>
 
     <script type="module" src="../init.js"></script>
diff --git a/src/pages/options/reddit/reddit.html b/src/pages/options/reddit/reddit.html
index 9dd59d73..c968b954 100644
--- a/src/pages/options/reddit/reddit.html
+++ b/src/pages/options/reddit/reddit.html
@@ -45,23 +45,6 @@
                 <option value="teddit">Teddit</option>
             </select>
         </div>
-
-        <!-- <section class="settings-block">
-            <h4>LibReddit Instance List</h4>
-            <div class="random-pool">
-                <textarea id="libreddit-random-pool" type="text"></textarea>
-                <ul id="libreddit-random-pool-list"></ul>
-            </div>
-        </section>
-
-        <section class="settings-block">
-            <h4>Teddit Instance List</h4>
-            <div class="random-pool">
-                <textarea id="teddit-random-pool" type="text"></textarea>
-                <ul id="teddit-random-pool-list"></ul>
-            </div>
-        </section> -->
-
     </section>
 
     <script type="module" src="../init.js"></script>
diff --git a/src/pages/options/search/search.html b/src/pages/options/search/search.html
index af7d3946..489ed38a 100644
--- a/src/pages/options/search/search.html
+++ b/src/pages/options/search/search.html
@@ -44,23 +44,6 @@
                 <option value="whoogle">Whoogle</option>
             </select>
         </div>
-<!-- 
-        <section class="settings-block">
-            <h4>SearX Instance List</h4>
-            <div class="random-pool">
-                <textarea id="searx-random-pool" type="text"></textarea>
-                <ul id="searx-random-pool-list"></ul>
-            </div>
-        </section>
-
-        <section class="settings-block">
-            <h4>Whoogle Instance List</h4>
-            <div class="random-pool">
-                <textarea id="whoogle-random-pool" type="text"></textarea>
-                <ul id="whoogle-random-pool-list"></ul>
-            </div>
-        </section> -->
-
     </section>
 
 
diff --git a/src/pages/options/twitter/twitter.html b/src/pages/options/twitter/twitter.html
index b13d02dd..8e189856 100644
--- a/src/pages/options/twitter/twitter.html
+++ b/src/pages/options/twitter/twitter.html
@@ -30,22 +30,6 @@
             <h4>Enable</h4>
             <input id="disable-nitter" type="checkbox" checked />
         </div>
-        <!-- <div class="some-block option-block">
-            <h4>Instance</h4>
-            <div class="autocomplete">
-                <input id="nitter-instance" type="url" name="nitter-instance"
-                    data-localise-placeholder="__MSG_randomInstancePlaceholder__"
-                    placeholder="Random instance (none selected)" />
-            </div>
-        </div> -->
-
-        <!-- <section class="settings-block">
-            <h4>Instance List</h4>
-            <div class="random-pool">
-                <textarea id="nitter-random-pool" type="text"></textarea>
-                <ul id="nitter-random-pool-list"></ul>
-            </div>
-        </section> -->
         <div class="some-block option-block">
             <h4 data-localise="__MSG_removeTwitterSW__">Proactively remove Twitter service worker</h4>
             <input id="remove-twitter-sw" type="checkbox" checked />
diff --git a/src/pages/options/wikipedia/wikipedia.html b/src/pages/options/wikipedia/wikipedia.html
index a68f36a6..ed811e94 100644
--- a/src/pages/options/wikipedia/wikipedia.html
+++ b/src/pages/options/wikipedia/wikipedia.html
@@ -28,20 +28,6 @@
             <h4>Enable</h4>
             <input id="disable-wikipedia" type="checkbox" checked />
         </div>
-        <!-- <div class="some-block option-block">
-            <h4>Instance</h4>
-            <div class="autocomplete">
-                <input id="wikipedia-instance" type="url" placeholder="https://wikiless.org" />
-            </div>
-        </div>
-
-        <section class="settings-block">
-            <h4>Instance List</h4>
-            <div class="random-pool">
-                <textarea id="wikiless-random-pool" type="text"></textarea>
-                <ul id="wikiless-random-pool-list"></ul>
-            </div>
-        </section> -->
     </section>
 
     <script type="module" src="../init.js"></script>
diff --git a/src/pages/options/youtube/youtube.html b/src/pages/options/youtube/youtube.html
index a9bb6c63..0778b794 100644
--- a/src/pages/options/youtube/youtube.html
+++ b/src/pages/options/youtube/youtube.html
@@ -30,23 +30,6 @@
             <input id="disable-invidious" type="checkbox" checked />
         </div>
 
-        <!-- <div class="some-block option-block">
-            <h4>Instance</h4>
-            <div class="autocomplete">
-            <input id="invidious-instance" type="url" data-localise-placeholder="__MSG_randomInstancePlaceholder__"
-                placeholder="Random instance (none selected)" />
-            </div>
-        </div> -->
-
-        <!-- <section class="settings-block">
-            <h4>Instance List</h4>
-            <div class="random-pool">
-                <textarea type="textarea" id="invidious-random-pool" name="invidious-random-pool"
-                    type="text"></textarea>
-                <ul id="invidious-random-pool-list"></ul>
-            </div>
-        </section> -->
-
         <div class="some-block option-block">
             <h4>Frontend</h4>
             <select id="youtube-frontend">
@@ -59,7 +42,6 @@
         <hr>
 
         <div id="invidious-piped">
-
             <div class="some-block option-block">
                 <h4>Only Redirect Embedded-Video</h4>
                 <input id="only-embed" type="checkbox" checked />
@@ -108,7 +90,7 @@
             </div>
 
             <div class="some-block option-block">
-                <h4 data-localise="__MSG_invidiousAlwaysProxy__">Always proxy videos</h4>
+                <h4>Always proxy videos</h4>
                 <select id="invidious-always-proxy">
                     <option value="DEFAULT">Default</option>
                     <option value="true">True</option>
@@ -151,7 +133,6 @@
                 <h4>Custom Instances</h4>
             </div>
 
-
             <form id="custom-instance-form">
                 <div class="some-block option-block">
                     <input id="invidious-custom-instance" placeholder="https://invidious.com" type="url" />
diff --git a/src/pages/options/youtube/youtube.js b/src/pages/options/youtube/youtube.js
index 595006fd..dcd8c22d 100644
--- a/src/pages/options/youtube/youtube.js
+++ b/src/pages/options/youtube/youtube.js
@@ -69,10 +69,8 @@ invidiousPlayerStyleElement.addEventListener("change",
 );
 
 let invidiousSubtitlesElement = document.getElementById("invidious-subtitles");
-invidiousSubtitlesElement.addEventListener("input",
-    commonHelper.debounce(() => {
-        youtubeHelper.setInvidiousSubtitles(invidiousSubtitlesElement.value)
-    }, 500)
+invidiousSubtitlesElement.addEventListener("change",
+    () => youtubeHelper.setInvidiousSubtitles(invidiousSubtitlesElement.value)
 );
 
 let invidiousAutoplayElement = document.getElementById("invidious-autoplay");
@@ -124,62 +122,51 @@ youtubeHelper.init().then(() => {
 
     let myMightyList = youtubeHelper.getInvidiousRedirectsChecks();
 
-    function checkToggleAll() {
-        console.log("CheckToggleAll")
-        let isTrue = true;
-        for (const item of youtubeHelper.getRedirects().invidious.normal)
-            if (!myMightyList.includes(item)) {
-                isTrue = false;
-                break;
-            }
-        document.getElementById('invidious-toogle-all').checked = isTrue;
-    }
-
-
     let checklistList = invidiousCheckListElement.getElementsByTagName('input')
     for (let element of checklistList) {
-
         element.checked = myMightyList.includes(element.id);
-
         if (element.id == 'invidious-toogle-all')
-            document.getElementById('invidious-toogle-all').addEventListener("change",
-                (event) => {
-                    if (event.target.checked) {
-                        for (let item of checklistList) {
-                            myMightyList.push(item.id)
-                            item.checked = true;
-                        }
-                    }
-                    else {
-                        myMightyList = [];
-                        for (let item of checklistList) item.checked = false;
+            document.getElementById('invidious-toogle-all').addEventListener("change", (event) => {
+                if (event.target.checked)
+                    for (let item of checklistList) {
+                        myMightyList.push(item.id);
+                        item.checked = true;
                     }
-                    youtubeHelper.setInvidiousRedirectsChecks(myMightyList);
+                else {
+                    myMightyList = [];
+                    for (let item of checklistList) item.checked = false;
                 }
-            );
+                youtubeHelper.setInvidiousRedirectsChecks(myMightyList);
+            });
         else
-            document.getElementById(element.id).addEventListener("change",
-                (event) => {
-                    if (event.target.checked)
-                        myMightyList.push(element.id)
-                    else {
-                        let index = myMightyList.indexOf(element.id);
-                        if (index > -1) myMightyList.splice(index, 1);
-                    }
-
-                    youtubeHelper.setInvidiousRedirectsChecks(myMightyList);
-                    checkToggleAll();
+            document.getElementById(element.id).addEventListener("change", (event) => {
+                if (event.target.checked)
+                    myMightyList.push(element.id)
+                else {
+                    let index = myMightyList.indexOf(element.id);
+                    if (index > -1) myMightyList.splice(index, 1);
                 }
-            );
+                youtubeHelper.setInvidiousRedirectsChecks(myMightyList);
+                checkToggleAll();
+            });
     }
     checkToggleAll();
 
-
     mightyInvidiousCustomInstances = youtubeHelper.getInvidiousCustomRedirects();
     calcCustom();
 
 });
 
+function checkToggleAll() {
+    let isTrue = true;
+    for (const item of youtubeHelper.getRedirects().invidious.normal)
+        if (!myMightyList.includes(item)) {
+            isTrue = false;
+            break;
+        }
+    document.getElementById('invidious-toogle-all').checked = isTrue;
+}
+
 
 let invidiousCustomInstanceElement = document.getElementById("invidious-custom-instance")
 let mightyInvidiousCustomInstances = []