diff options
| author | Leonidas Loucas <311356+merc1031@users.noreply.github.com> | 2025-12-15 10:21:02 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-12-15 13:21:02 -0500 |
| commit | 7867eb0e785ecf7241e2e62f67b09880b42fbb0c (patch) | |
| tree | 4bd2029806d8a9011b0cf512e0d5031589469e81 /flake.lock | |
| parent | docs: Migrate docs from separate repo to `docs` subfolder (#3018) (diff) | |
| download | atuin-7867eb0e785ecf7241e2e62f67b09880b42fbb0c.zip | |
fix: Move thorough search through search.filters w/ workspaces (#2703)
Do not just pick first from search.filters, consider all options,
filtering based on git-root and workspaces config
Fix: atuinsh/atuin#2700
Might Fix: atuinsh/atuin#2536
Wrote a few simple unit tests, and tried it by running the client
locally. Not sure about which of "[search] filters" vs "workspaces"
should be more respected, so i made it so if workspaces = false,
regardless of whats in "[search] filters" workspace gets filtered out.
First time looking at atuins code, let me know if this needs any
changes.
edit: (from my post here:
https://github.com/atuinsh/atuin/issues/2536#issuecomment-2808053862)
```
workspaces = true
[search]
filters = [ "workspace", "directory", "session", "global" ]
```
| `^R` for the ... time| in a git repo | any other dir|
| ------------- | ------------- | ------------- |
| first | workspace | directory|
| second | directory | session|
| third| session | global|
| fourth | global | directory |
| fifth | workspace | session|
| sixth | directory | global |

<!-- Thank you for making a PR! Bug fixes are always welcome, but if
you're adding a new feature or changing an existing one, we'd really
appreciate if you open an issue, post on the forum, or drop in on
Discord -->
## Checks
- [X] I am happy for maintainers to push small adjustments to this PR,
to speed up the review cycle
- [X] I have checked that there are no existing pull requests for the
same thing
- #1655 might be related, but it seems to also implement code that is
already merged, and has been open for over a year, hope its ok to
suggest this
---------
Co-authored-by: Michelle Tilley <michelle@michelletilley.net>
Diffstat (limited to 'flake.lock')
0 files changed, 0 insertions, 0 deletions
