diff options
| author | Ellie Huxtable <ellie@atuin.sh> | 2026-01-23 12:27:43 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2026-01-23 12:27:43 -0800 |
| commit | 126070068abda34fda0b880a36cc604b4ac8be2a (patch) | |
| tree | 1b5529df0adca1a228fa107bfe2ee9bf240e7f61 /crates/atuin-server-sqlite/src | |
| parent | chore(deps)!: update tls deps, remove built-in tls server support (#3091) (diff) | |
| download | atuin-126070068abda34fda0b880a36cc604b4ac8be2a.zip | |
chore!: remove total_history from api index response (#3094)
Remove the expensive and inaccurate `total_history` field from the API
index endpoint. The query `select sum(total) from
total_history_count_user` ran on every request but is no longer
relevant. The underlying table remains for per-user cached counts used
by `/sync/count`.
## Checks
- [x] I am happy for maintainers to push small adjustments to this PR,
to speed up the review cycle
- [x] I have checked that there are no existing pull requests for the
same thing
Diffstat (limited to 'crates/atuin-server-sqlite/src')
| -rw-r--r-- | crates/atuin-server-sqlite/src/lib.rs | 11 |
1 files changed, 0 insertions, 11 deletions
diff --git a/crates/atuin-server-sqlite/src/lib.rs b/crates/atuin-server-sqlite/src/lib.rs index 9cc1e8a7..83d05ea5 100644 --- a/crates/atuin-server-sqlite/src/lib.rs +++ b/crates/atuin-server-sqlite/src/lib.rs @@ -232,17 +232,6 @@ impl Database for Sqlite { } #[instrument(skip_all)] - async fn total_history(&self) -> DbResult<i64> { - let res: (i64,) = sqlx::query_as("select count(1) from history") - .fetch_optional(&self.pool) - .await - .map_err(fix_error)? - .unwrap_or((0,)); - - Ok(res.0) - } - - #[instrument(skip_all)] async fn count_history(&self, user: &User) -> DbResult<i64> { // The cache is new, and the user might not yet have a cache value. // They will have one as soon as they post up some new history, but handle that |
