diff options
| author | Rain <rain@sunshowers.io> | 2024-03-05 01:49:40 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-03-05 09:49:40 +0000 |
| commit | 95e9530dad098e69de560a3f4d198b5c05cc53ba (patch) | |
| tree | dcb77716883d7c1bf32212945bf2bebababd3d29 /atuin-server-database/src | |
| parent | fix(sync): record size limiter (#1827) (diff) | |
| download | atuin-95e9530dad098e69de560a3f4d198b5c05cc53ba.zip | |
fix(build): make atuin compile on non-win/mac/linux platforms (#1825)
Hi!
I've been trying to get atuin set up on the illumos machine I built for work
@oxidecomputer, and I ran into a few issues which are fixed here:
1. The `clipboard` feature was only supported on Windows, Mac and Linux. I've
added a platform gate for that.
2. The `atomic-write-file` crate needed an update to the version of `nix` --
that is included.
3. As part of this, I found a [security
bug](https://rustsec.org/advisories/RUSTSEC-2024-0020.html) in the whoami
crate. The bug has been fixed upstream and I've included it.
whoami 1.5.0 deprecates the `hostname` function, which produced some fresh
warnings. While fixing the warnings I also took the liberty of doing some
code rearrangement, adding a few functions that wrap some common operations. I
didn't really know where to put those functions, so I created a new `utils`
module for it. If you have a better place to put them, I'm happy to change
the PR.
Feel free to make any changes to this PR if you like before landing it, or to
ask for review.
As a followup I'm also happy to set up a cross-compile build for atuin on
illumos. It's a bit harder to run tests in CI for illumos at the moment, but
I'm trying to get a project started up to make that happen in the future as
well.
Diffstat (limited to 'atuin-server-database/src')
0 files changed, 0 insertions, 0 deletions