diff options
| author | Jonathan Hult <jonathan@jonathanhult.com> | 2025-12-10 13:28:24 -0600 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-12-10 11:28:24 -0800 |
| commit | 8ef7a963eb51ca8b0ff237c37ca6eb0c4948b7cb (patch) | |
| tree | 85ee4f131020f415bbe805ecad584dd5dc942b15 | |
| parent | ci: fix github action syntax for variables (#2998) (diff) | |
| download | atuin-8ef7a963eb51ca8b0ff237c37ca6eb0c4948b7cb.zip | |
fix: prevent interactive search crash when update check fails (#3016)
Relates to #2520 - Gracefully handle update check failures instead of
crashing the entire interactive search UI.
## Checks
- [x] I am happy for maintainers to push small adjustments to this PR,
to speed up the review cycle
- [x] I have checked that there are no existing pull requests for the
same thing
| -rw-r--r-- | crates/atuin/src/command/client/search/interactive.rs | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/crates/atuin/src/command/client/search/interactive.rs b/crates/atuin/src/command/client/search/interactive.rs index 0b86462e..b01e75db 100644 --- a/crates/atuin/src/command/client/search/interactive.rs +++ b/crates/atuin/src/command/client/search/interactive.rs @@ -1355,7 +1355,9 @@ pub async fn history( } } update_needed = &mut update_needed => { - app.update_needed = update_needed?; + // Don't fail interactive search if update check fails + // The update check is a nice-to-have feature, not critical + app.update_needed = update_needed.ok().flatten(); } } |