From 6ca6689936b11570a82bcffa704e8eda35223b2a Mon Sep 17 00:00:00 2001 From: ManeraKai Date: Fri, 25 Feb 2022 19:43:10 +0300 Subject: Added youtube embed exceptions #46 --- src/assets/javascripts/helpers/exceptions.js | 1 - src/assets/javascripts/helpers/youtube/youtube.js | 36 +++++++++- src/pages/background/background.js | 3 +- src/pages/options/youtube/embed-exceptions.js | 80 +++++++++++++++++++++++ src/pages/options/youtube/youtube.html | 29 ++++++++ 5 files changed, 145 insertions(+), 4 deletions(-) create mode 100644 src/pages/options/youtube/embed-exceptions.js (limited to 'src') diff --git a/src/assets/javascripts/helpers/exceptions.js b/src/assets/javascripts/helpers/exceptions.js index 5969cc4c..7c6e4798 100644 --- a/src/assets/javascripts/helpers/exceptions.js +++ b/src/assets/javascripts/helpers/exceptions.js @@ -1,7 +1,6 @@ "use strict"; window.browser = window.browser || window.chrome; - let exceptions = { "url": [], "regex": [], diff --git a/src/assets/javascripts/helpers/youtube/youtube.js b/src/assets/javascripts/helpers/youtube/youtube.js index b10ceb76..55f18555 100644 --- a/src/assets/javascripts/helpers/youtube/youtube.js +++ b/src/assets/javascripts/helpers/youtube/youtube.js @@ -238,6 +238,28 @@ function setAlwaysusePreferred(val) { console.log("alwaysusePreferred: ", alwaysusePreferred) } +let exceptions = { + "url": [], + "regex": [], +}; +const getExceptions = () => exceptions; +function setExceptions(val) { + exceptions = val; + browser.storage.local.set({ youtubeEmbedExceptions: val }) + console.log("youtubeEmbedExceptions: ", val) +} + +function isException(url) { + for (const item of exceptions.url) { + let protocolHost = `${url.protocol}//${url.host}` + console.log(item, protocolHost) + if (item == protocolHost) return true; + } + for (const item of exceptions.regex) + if (new RegExp(item).test(url.href)) return true; + return false; +} + function isYoutube(url, initiator) { if (disable) return false; if ( @@ -300,7 +322,11 @@ function isYoutube(url, initiator) { return isTargets } -function redirect(url, type) { +function redirect(url, type, details) { + if (type != "main_frame" && details.frameAncestors.length > 0 && isException(new URL(details.frameAncestors[0].url))) { + console.log(`Canceled ${url.href}`, details.frameAncestors[0].url) + return null; + } if (url.pathname.match(/iframe_api/) || url.pathname.match(/www-widgetapi/)) return null; // Don't redirect YouTube Player API. if (frontend == 'yatte' && type === "main_frame") @@ -536,6 +562,8 @@ async function init() { "youtubeEmbedFrontend", "youtubeProtocol", + + "youtubeEmbedExceptions" ], (result) => { redirects.invidious = dataJson.invidious; @@ -572,6 +600,8 @@ async function init() { alwaysusePreferred = result.alwaysusePreferred ?? true; + if (result.youtubeEmbedExceptions) exceptions = result.youtubeEmbedExceptions; + resolve(); }); }); @@ -660,5 +690,9 @@ export default { getAlwaysusePreferred, setAlwaysusePreferred, + getExceptions, + setExceptions, + isException, + init, }; diff --git a/src/pages/background/background.js b/src/pages/background/background.js index 71ae568a..1f91ad4d 100644 --- a/src/pages/background/background.js +++ b/src/pages/background/background.js @@ -50,8 +50,7 @@ browser.webRequest.onBeforeRequest.addListener( if (exceptionsHelper.isException(url, initiator)) newUrl = null; else if (youtubeMusicHelper.isYoutubeMusic(url, initiator)) newUrl = youtubeMusicHelper.redirect(url, details.type) - - else if (youtubeHelper.isYoutube(url, initiator)) newUrl = youtubeHelper.redirect(url, details.type) + else if (youtubeHelper.isYoutube(url, initiator)) newUrl = youtubeHelper.redirect(url, details.type, details) else if (twitterHelper.isTwitter(url, initiator)) newUrl = twitterHelper.redirect(url); diff --git a/src/pages/options/youtube/embed-exceptions.js b/src/pages/options/youtube/embed-exceptions.js new file mode 100644 index 00000000..ca2900d4 --- /dev/null +++ b/src/pages/options/youtube/embed-exceptions.js @@ -0,0 +1,80 @@ +"use strict"; +window.browser = window.browser || window.chrome; + +import youtubeHelper from "../../../assets/javascripts/helpers/youtube/youtube.js"; + +let nameCustomInstanceInput = document.getElementById("exceptions-custom-instance"); +let instanceTypeElement = document.getElementById("exceptions-custom-instance-type"); +let instanceType = "url" + +youtubeHelper.init().then(() => { + instanceTypeElement.addEventListener("change", + (event) => { + instanceType = event.target.options[instanceTypeElement.selectedIndex].value + if (instanceType == 'url') { + nameCustomInstanceInput.setAttribute("type", "url"); + nameCustomInstanceInput.setAttribute("placeholder", "https://www.google.com"); + } + else if (instanceType == 'regex') { + nameCustomInstanceInput.setAttribute("type", "text"); + nameCustomInstanceInput.setAttribute("placeholder", "https?:\/\/(www\.|music|)youtube\.com\/watch\?v\=..*"); + } + } + ) + let exceptionsCustomInstances = youtubeHelper.getExceptions(); + function calcExceptionsCustomInstances() { + console.log("exceptionsCustomInstances", exceptionsCustomInstances) + document.getElementById("exceptions-custom-checklist").innerHTML = + [...exceptionsCustomInstances.url, ...exceptionsCustomInstances.regex].map( + (x) => `
${x} +
+
` + ).join('\n'); + + for (const x of [...exceptionsCustomInstances.url, ...exceptionsCustomInstances.regex]) { + document.getElementById(`clear-${x}`).addEventListener("click", + () => { + console.log(x); + let index; + index = exceptionsCustomInstances.url.indexOf(x); + if (index > -1) + exceptionsCustomInstances.url.splice(index, 1); + else { + index = exceptionsCustomInstances.regex.indexOf(x); + if (index > -1) + exceptionsCustomInstances.regex.splice(index, 1); + } + youtubeHelper.setExceptions(exceptionsCustomInstances); + calcExceptionsCustomInstances(); + }); + } + } + calcExceptionsCustomInstances(); + document.getElementById("custom-exceptions-instance-form").addEventListener("submit", (event) => { + event.preventDefault(); + + let val + if (instanceType == 'url') { + if (nameCustomInstanceInput.validity.valid) { + let url = new URL(nameCustomInstanceInput.value); + val = `${url.protocol}//${url.host}` + if (!exceptionsCustomInstances.url.includes(val)) exceptionsCustomInstances.url.push(val) + } + } else if (instanceType == 'regex') { + val = nameCustomInstanceInput.value + if (val.trim() != '' && !exceptionsCustomInstances.regex.includes(val)) exceptionsCustomInstances.regex.push(val) + } + if (val) { + youtubeHelper.setExceptions(exceptionsCustomInstances); + console.log("exceptionsCustomInstances", exceptionsCustomInstances) + nameCustomInstanceInput.value = ''; + } + calcExceptionsCustomInstances(); + }) +}) \ No newline at end of file diff --git a/src/pages/options/youtube/youtube.html b/src/pages/options/youtube/youtube.html index d35c5c91..0fb4f195 100644 --- a/src/pages/options/youtube/youtube.html +++ b/src/pages/options/youtube/youtube.html @@ -346,12 +346,41 @@ +
+ +
+

Embed Exceptions

+
+
+
+
+ +   + +   +
+ +
+
+
+ + + + -- cgit 1.4.1