From fbdfe07425a46a6f42b50ad745ec5a701c7f1ebf Mon Sep 17 00:00:00 2001 From: ManeraKai Date: Sun, 30 Jan 2022 23:36:07 +0300 Subject: Cleaning code and changing naming schemes --- src/pages/options/reddit.js | 41 +++++++++++++++++------------------------ 1 file changed, 17 insertions(+), 24 deletions(-) (limited to 'src/pages/options/reddit.js') diff --git a/src/pages/options/reddit.js b/src/pages/options/reddit.js index 9f515d5c..affc7a88 100644 --- a/src/pages/options/reddit.js +++ b/src/pages/options/reddit.js @@ -5,9 +5,9 @@ import shared from "./shared.js"; const redditInstances = redditHelper.redirects; -let redditInstance = document.getElementById("reddit-instance"); -let disableReddit = document.getElementById("disable-reddit"); -let redditFrontend = document.getElementById("reddit-frontend"); +let redditInstanceElement = document.getElementById("reddit-instance"); +let disableRedditElement = document.getElementById("disable-reddit"); +let redditFrontendElement = document.getElementById("reddit-frontend"); browser.storage.sync.get( [ @@ -16,9 +16,9 @@ browser.storage.sync.get( "redditFrontend" ], (result) => { - redditInstance.value = result.redditInstance || ""; - disableReddit.checked = !result.disableReddit; - redditFrontend.value = result.redditFrontend; + redditInstanceElement.value = result.redditInstance || ""; + disableRedditElement.checked = !result.disableReddit; + redditFrontendElement.value = result.redditFrontend; let id = "reddit-instance"; let instances = redditInstances; shared.autocompletes.push({ id: id, instances: instances }) @@ -26,27 +26,20 @@ browser.storage.sync.get( } ) -const redditInstanceChange = commonHelper.debounce( - () => { - if (redditInstance.checkValidity()) { - browser.storage.sync.set({ - redditInstance: shared.parseURL(redditInstance.value), - }); - } - }, - 500 -); - -redditInstance.addEventListener("input", redditInstanceChange); +redditInstanceElement.addEventListener("input", commonHelper.debounce(() => { + if (redditInstanceElement.checkValidity()) { + browser.storage.sync.set({ + redditInstance: shared.parseURL(redditInstanceElement.value), + }); + } +}, 500)); -disableReddit.addEventListener("change", (event) => { +disableRedditElement.addEventListener("change", (event) => { browser.storage.sync.set({ disableReddit: !event.target.checked }); }); -redditFrontend.addEventListener("change", (event) => { - const value = event.target.options[redditFrontend.selectedIndex].value; +redditFrontendElement.addEventListener("change", (event) => { + const value = event.target.options[redditFrontendElement.selectedIndex].value; console.info("Reddit Frontend", value) - browser.storage.sync.set({ - redditFrontend: value, - }) + browser.storage.sync.set({ redditFrontend: value }) }) \ No newline at end of file -- cgit 1.4.1