From 5d4377c081d18d89e64184c60d3fa97504768c81 Mon Sep 17 00:00:00 2001 From: ManeraKai Date: Tue, 12 Apr 2022 02:27:39 +0300 Subject: Restructuring Settings Structure --- src/assets/javascripts/helpers/common.js | 31 ++-- src/assets/javascripts/helpers/twitter.js | 14 ++ src/assets/javascripts/helpers/wikipedia.js | 4 +- src/assets/javascripts/helpers/youtube/options.js | 149 +------------------ src/assets/javascripts/helpers/youtube/youtube.js | 170 +++++----------------- 5 files changed, 75 insertions(+), 293 deletions(-) (limited to 'src/assets') diff --git a/src/assets/javascripts/helpers/common.js b/src/assets/javascripts/helpers/common.js index cf95d913..65810db4 100644 --- a/src/assets/javascripts/helpers/common.js +++ b/src/assets/javascripts/helpers/common.js @@ -88,9 +88,10 @@ function processDefaultCustomInstances( getNameCustomRedirects, setNameCustomRedirects ) { + let nameProtocolElement = document.getElementById(name).getElementsByClassName(protocol)[0]; let nameCustomInstances = []; - let nameCheckListElement = document.getElementById(`${name}-${protocol}-checklist`); + let nameCheckListElement = nameProtocolElement.getElementsByClassName('checklist')[0]; let nameDefaultRedirects; function calcNameCheckBoxes() { @@ -101,22 +102,22 @@ function processDefaultCustomInstances( break; } for (const element of nameCheckListElement.getElementsByTagName('input')) - element.checked = nameDefaultRedirects.includes(element.id) - document.getElementById(`${name}-${protocol}-toogle-all`).checked = isTrue; + element.checked = nameDefaultRedirects.includes(element.className) + nameProtocolElement.getElementsByClassName('toogle-all')[0].checked = isTrue; } nameDefaultRedirects = getNameRedirectsChecks(); nameCheckListElement.innerHTML = [ - `
Toggle All
`, - ...nameHelper.getRedirects()[name][protocol].map((x) => `
${x}
`), + `
Toggle All
`, + ...nameHelper.getRedirects()[name][protocol].map((x) => `
${x}
`), ].join('\n
\n'); localise.localisePage(); calcNameCheckBoxes(); - document.getElementById(`${name}-${protocol}-toogle-all`).addEventListener("change", event => { + nameProtocolElement.getElementsByClassName('toogle-all')[0].addEventListener("change", event => { if (event.target.checked) nameDefaultRedirects = [...nameHelper.getRedirects()[name][protocol]]; else @@ -126,12 +127,12 @@ function processDefaultCustomInstances( }); for (let element of nameCheckListElement.getElementsByTagName('input')) { - if (element.id != `${name}-${protocol}-toogle-all`) - document.getElementById(element.id).addEventListener("change", (event) => { + if (element.className != 'toogle-all') + nameProtocolElement.getElementsByClassName(element.className)[0].addEventListener("change", event => { if (event.target.checked) - nameDefaultRedirects.push(element.id) + nameDefaultRedirects.push(element.className) else { - let index = nameDefaultRedirects.indexOf(element.id); + let index = nameDefaultRedirects.indexOf(element.className); if (index > -1) nameDefaultRedirects.splice(index, 1); } setNameRedirectsChecks(nameDefaultRedirects); @@ -141,9 +142,9 @@ function processDefaultCustomInstances( nameCustomInstances = getNameCustomRedirects(); function calcNameCustomInstances() { - document.getElementById(`${name}-${protocol}-custom-checklist`).innerHTML = + nameProtocolElement.getElementsByClassName('custom-checklist')[0].innerHTML = nameCustomInstances.map( - (x) => `
${x}