From 2603e7a9ea7bd12b40d88e799ff377a8960cccaf Mon Sep 17 00:00:00 2001
From: nitrohorse <1514352+nitrohorse@users.noreply.github.com>
Date: Sat, 5 Sep 2020 22:21:41 -0700
Subject: Update Reddit-related text for consistency, bugfix

Even when on an old Reddit view, redirect from desktop or mobile
depending on whichever one the redirect is set to.
---
 pages/options/options.html | 14 +++++++-------
 pages/options/options.js   | 32 ++++++++++++++++----------------
 2 files changed, 23 insertions(+), 23 deletions(-)

(limited to 'pages/options')

diff --git a/pages/options/options.html b/pages/options/options.html
index 96641515..bf9d5cdb 100644
--- a/pages/options/options.html
+++ b/pages/options/options.html
@@ -121,22 +121,22 @@
         </table>
       </section>
       <section class="settings-block">
-        <table class="option" aria-label="Toggle Reddit version redirects">
+        <table class="option" aria-label="Toggle old Reddit redirects">
           <tbody>
             <tr>
               <td>
-                <h1 data-localise="__MSG_disableRedditVersion__">
-                  Reddit Version Redirects
+                <h1 data-localise="__MSG_disableOldReddit__">
+                  Old Reddit Redirects
                 </h1>
               </td>
               <td>
                 <input
                   aria-hidden="true"
-                  id="disable-reddit-version"
+                  id="disable-old-reddit"
                   type="checkbox"
                   checked
                 />&nbsp;
-                <label for="disable-reddit-version" class="checkbox-label"> </label>
+                <label for="disable-old-reddit" class="checkbox-label"> </label>
               </td>
             </tr>
           </tbody>
@@ -184,10 +184,10 @@
         </div>
       </section>
       <section class="settings-block">
-        <h1 data-localise="__MSG_redditVersion__">Reddit Version</h1>
+        <h1 data-localise="__MSG_oldRedditView__">Old Reddit View (Desktop or Mobile)</h1>
         <div class="autocomplete">
           <input
-            id="reddit-version"
+            id="old-reddit-view"
             type="url"
             placeholder="https://old.reddit.com"
           />
diff --git a/pages/options/options.js b/pages/options/options.js
index ff08fa43..65133581 100644
--- a/pages/options/options.js
+++ b/pages/options/options.js
@@ -45,28 +45,28 @@ const bibliogramInstances = [
   "https://bibliogram.ggc-project.de",
 ];
 const osmInstances = ["https://openstreetmap.org"];
-const redditVersions = [
-  "https://old.reddit.com",
-  "https://i.reddit.com"
+const oldRedditViews = [
+  "https://old.reddit.com", // desktop
+  "https://i.reddit.com" // mobile
 ];
 const autocompletes = [
   { id: "nitter-instance", instances: nitterInstances },
   { id: "invidious-instance", instances: invidiousInstances },
   { id: "bibliogram-instance", instances: bibliogramInstances },
   { id: "osm-instance", instances: osmInstances },
-  { id: "reddit-version", instances: redditVersions },
+  { id: "old-reddit-view", instances: oldRedditViews },
 ];
 
 let nitterInstance = document.getElementById("nitter-instance");
 let invidiousInstance = document.getElementById("invidious-instance");
 let bibliogramInstance = document.getElementById("bibliogram-instance");
 let osmInstance = document.getElementById("osm-instance");
-let redditVersion = document.getElementById("reddit-version");
+let oldRedditView = document.getElementById("old-reddit-view");
 let disableNitter = document.getElementById("disable-nitter");
 let disableInvidious = document.getElementById("disable-invidious");
 let disableBibliogram = document.getElementById("disable-bibliogram");
 let disableOsm = document.getElementById("disable-osm");
-let disableRedditVersion = document.getElementById("disable-reddit-version");
+let disableOldReddit = document.getElementById("disable-old-reddit");
 let alwaysProxy = document.getElementById("always-proxy");
 let onlyEmbeddedVideo = document.getElementById("only-embed");
 let videoQuality = document.getElementById("video-quality");
@@ -110,12 +110,12 @@ browser.storage.sync.get(
     "invidiousInstance",
     "bibliogramInstance",
     "osmInstance",
-    "redditVersion",
+    "oldRedditView",
     "disableNitter",
     "disableInvidious",
     "disableBibliogram",
     "disableOsm",
-    "disableRedditVersion",
+    "disableOldReddit",
     "alwaysProxy",
     "onlyEmbeddedVideo",
     "videoQuality",
@@ -136,12 +136,12 @@ browser.storage.sync.get(
     invidiousInstance.value = result.invidiousInstance || "";
     bibliogramInstance.value = result.bibliogramInstance || "";
     osmInstance.value = result.osmInstance || "";
-    redditVersion.value = result.redditVersion || "";
+    oldRedditView.value = result.oldRedditView || "";
     disableNitter.checked = !result.disableNitter;
     disableInvidious.checked = !result.disableInvidious;
     disableBibliogram.checked = !result.disableBibliogram;
     disableOsm.checked = !result.disableOsm;
-    disableRedditVersion.checked = !result.disableRedditVersion;
+    disableOldReddit.checked = !result.disableOldReddit;
     alwaysProxy.checked = result.alwaysProxy;
     onlyEmbeddedVideo.checked = result.onlyEmbeddedVideo;
     videoQuality.value = result.videoQuality || "";
@@ -284,14 +284,14 @@ let osmInstanceChange = debounce(() => {
 }, 500);
 osmInstance.addEventListener("input", osmInstanceChange);
 
-let redditVersionChange = debounce(() => {
-  if (redditVersion.checkValidity()) {
+let oldRedditViewChange = debounce(() => {
+  if (oldRedditView.checkValidity()) {
     browser.storage.sync.set({
-      redditVersion: parseURL(redditVersion.value),
+      oldRedditView: parseURL(oldRedditView.value),
     });
   }
 }, 500);
-redditVersion.addEventListener("input", redditVersionChange);
+oldRedditView.addEventListener("input", oldRedditViewChange);
 
 disableNitter.addEventListener("change", (event) => {
   browser.storage.sync.set({ disableNitter: !event.target.checked });
@@ -309,8 +309,8 @@ disableOsm.addEventListener("change", (event) => {
   browser.storage.sync.set({ disableOsm: !event.target.checked });
 });
 
-disableRedditVersion.addEventListener("change", (event) => {
-  browser.storage.sync.set({ disableRedditVersion: !event.target.checked });
+disableOldReddit.addEventListener("change", (event) => {
+  browser.storage.sync.set({ disableOldReddit: !event.target.checked });
 });
 
 alwaysProxy.addEventListener("change", (event) => {
-- 
cgit 1.4.1