diff --git a/pages/options/options.js b/pages/options/options.js
index ff08fa43..65133581 100644
--- a/pages/options/options.js
+++ b/pages/options/options.js
@@ -45,28 +45,28 @@ const bibliogramInstances = [
"https://bibliogram.ggc-project.de",
];
const osmInstances = ["https://openstreetmap.org"];
-const redditVersions = [
- "https://old.reddit.com",
- "https://i.reddit.com"
+const oldRedditViews = [
+ "https://old.reddit.com", // desktop
+ "https://i.reddit.com" // mobile
];
const autocompletes = [
{ id: "nitter-instance", instances: nitterInstances },
{ id: "invidious-instance", instances: invidiousInstances },
{ id: "bibliogram-instance", instances: bibliogramInstances },
{ id: "osm-instance", instances: osmInstances },
- { id: "reddit-version", instances: redditVersions },
+ { id: "old-reddit-view", instances: oldRedditViews },
];
let nitterInstance = document.getElementById("nitter-instance");
let invidiousInstance = document.getElementById("invidious-instance");
let bibliogramInstance = document.getElementById("bibliogram-instance");
let osmInstance = document.getElementById("osm-instance");
-let redditVersion = document.getElementById("reddit-version");
+let oldRedditView = document.getElementById("old-reddit-view");
let disableNitter = document.getElementById("disable-nitter");
let disableInvidious = document.getElementById("disable-invidious");
let disableBibliogram = document.getElementById("disable-bibliogram");
let disableOsm = document.getElementById("disable-osm");
-let disableRedditVersion = document.getElementById("disable-reddit-version");
+let disableOldReddit = document.getElementById("disable-old-reddit");
let alwaysProxy = document.getElementById("always-proxy");
let onlyEmbeddedVideo = document.getElementById("only-embed");
let videoQuality = document.getElementById("video-quality");
@@ -110,12 +110,12 @@ browser.storage.sync.get(
"invidiousInstance",
"bibliogramInstance",
"osmInstance",
- "redditVersion",
+ "oldRedditView",
"disableNitter",
"disableInvidious",
"disableBibliogram",
"disableOsm",
- "disableRedditVersion",
+ "disableOldReddit",
"alwaysProxy",
"onlyEmbeddedVideo",
"videoQuality",
@@ -136,12 +136,12 @@ browser.storage.sync.get(
invidiousInstance.value = result.invidiousInstance || "";
bibliogramInstance.value = result.bibliogramInstance || "";
osmInstance.value = result.osmInstance || "";
- redditVersion.value = result.redditVersion || "";
+ oldRedditView.value = result.oldRedditView || "";
disableNitter.checked = !result.disableNitter;
disableInvidious.checked = !result.disableInvidious;
disableBibliogram.checked = !result.disableBibliogram;
disableOsm.checked = !result.disableOsm;
- disableRedditVersion.checked = !result.disableRedditVersion;
+ disableOldReddit.checked = !result.disableOldReddit;
alwaysProxy.checked = result.alwaysProxy;
onlyEmbeddedVideo.checked = result.onlyEmbeddedVideo;
videoQuality.value = result.videoQuality || "";
@@ -284,14 +284,14 @@ let osmInstanceChange = debounce(() => {
}, 500);
osmInstance.addEventListener("input", osmInstanceChange);
-let redditVersionChange = debounce(() => {
- if (redditVersion.checkValidity()) {
+let oldRedditViewChange = debounce(() => {
+ if (oldRedditView.checkValidity()) {
browser.storage.sync.set({
- redditVersion: parseURL(redditVersion.value),
+ oldRedditView: parseURL(oldRedditView.value),
});
}
}, 500);
-redditVersion.addEventListener("input", redditVersionChange);
+oldRedditView.addEventListener("input", oldRedditViewChange);
disableNitter.addEventListener("change", (event) => {
browser.storage.sync.set({ disableNitter: !event.target.checked });
@@ -309,8 +309,8 @@ disableOsm.addEventListener("change", (event) => {
browser.storage.sync.set({ disableOsm: !event.target.checked });
});
-disableRedditVersion.addEventListener("change", (event) => {
- browser.storage.sync.set({ disableRedditVersion: !event.target.checked });
+disableOldReddit.addEventListener("change", (event) => {
+ browser.storage.sync.set({ disableOldReddit: !event.target.checked });
});
alwaysProxy.addEventListener("change", (event) => {
diff --git a/pages/popup/popup.html b/pages/popup/popup.html
index 871e2c62..faf0deb8 100644
--- a/pages/popup/popup.html
+++ b/pages/popup/popup.html
@@ -117,22 +117,22 @@
-
+
-
- Reddit Version Redirects
+
+ Old Reddit Redirects
|
-
+
|
diff --git a/pages/popup/popup.js b/pages/popup/popup.js
index 4ea627cd..34253702 100644
--- a/pages/popup/popup.js
+++ b/pages/popup/popup.js
@@ -4,7 +4,7 @@ let disableNitter = document.querySelector("#disable-nitter");
let disableInvidious = document.querySelector("#disable-invidious");
let disableBibliogram = document.querySelector("#disable-bibliogram");
let disableOsm = document.querySelector("#disable-osm");
-let disableRedditVersion = document.querySelector("#disable-reddit-version");
+let disableOldReddit = document.querySelector("#disable-old-reddit");
let version = document.querySelector("#version");
window.browser = window.browser || window.chrome;
@@ -15,7 +15,7 @@ browser.storage.sync.get(
"disableInvidious",
"disableBibliogram",
"disableOsm",
- "disableRedditVersion",
+ "disableOldReddit",
"theme",
],
(result) => {
@@ -24,7 +24,7 @@ browser.storage.sync.get(
disableInvidious.checked = !result.disableInvidious;
disableBibliogram.checked = !result.disableBibliogram;
disableOsm.checked = !result.disableOsm;
- disableRedditVersion.checked = !result.disableRedditVersion;
+ disableOldReddit.checked = !result.disableOldReddit;
}
);
@@ -46,8 +46,8 @@ disableOsm.addEventListener("change", (event) => {
browser.storage.sync.set({ disableOsm: !event.target.checked });
});
-disableRedditVersion.addEventListener("change", (event) => {
- browser.storage.sync.set({ disableRedditVersion: !event.target.checked });
+disableOldReddit.addEventListener("change", (event) => {
+ browser.storage.sync.set({ disableOldReddit: !event.target.checked });
});
document.querySelector("#more-options").addEventListener("click", () => {
--
cgit 1.4.1
From b9cd32cfaa923f965d67f673155e34b9ae4e7d82 Mon Sep 17 00:00:00 2001
From: nitrohorse <1514352+nitrohorse@users.noreply.github.com>
Date: Sat, 5 Sep 2020 22:31:15 -0700
Subject: Update variable for consistency
---
background.js | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/background.js b/background.js
index 5e896a13..49b99edb 100644
--- a/background.js
+++ b/background.js
@@ -95,7 +95,7 @@ const oldRedditViews = [
"https://old.reddit.com", // desktop
"https://i.reddit.com" // mobile
];
-const redditDefault = oldRedditViews[0];
+const oldRedditDefaultView = oldRedditViews[0];
const googleMapsRegex = /https?:\/\/(((www|maps)\.)?(google\.).*(\/maps)|maps\.(google\.).*)/;
const mapCentreRegex = /@(-?\d[0-9.]*),(-?\d[0-9.]*),(\d{1,2})[.z]/;
const dataLatLngRegex = /(!3d|!4d)(-?[0-9]{1,10}.[0-9]{1,10})/g;
@@ -167,7 +167,7 @@ browser.storage.sync.get(
invidiousInstance = result.invidiousInstance;
bibliogramInstance = result.bibliogramInstance;
osmInstance = result.osmInstance || osmDefault;
- oldRedditView = result.oldRedditView || redditDefault;
+ oldRedditView = result.oldRedditView || oldRedditDefaultView;
alwaysProxy = result.alwaysProxy;
onlyEmbeddedVideo = result.onlyEmbeddedVideo;
videoQuality = result.videoQuality;
@@ -198,7 +198,7 @@ browser.storage.onChanged.addListener((changes) => {
osmInstance = changes.osmInstance.newValue || osmDefault;
}
if ("oldRedditView" in changes) {
- oldRedditView = changes.oldRedditView.newValue || redditDefault;
+ oldRedditView = changes.oldRedditView.newValue || oldRedditDefaultView;
}
if ("disableNitter" in changes) {
disableNitter = changes.disableNitter.newValue;
--
cgit 1.4.1
From 27f538e50b487c896cf8b424d642cf7ba156545a Mon Sep 17 00:00:00 2001
From: nitrohorse <1514352+nitrohorse@users.noreply.github.com>
Date: Sat, 5 Sep 2020 22:32:23 -0700
Subject: Update comment for clarity
---
background.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/background.js b/background.js
index 49b99edb..94cb616c 100644
--- a/background.js
+++ b/background.js
@@ -505,7 +505,7 @@ function redirectReddit(url, initiator, type) {
if (initiator && initiator.origin === oldRedditView || url.origin === oldRedditView) {
return null;
}
- // Do not redirect anything other than main_frame
+ // Do not redirect exclusions nor anything other than main_frame
if (type !== "main_frame" || url.pathname.match(redditBypassPaths)) {
return null;
}
--
cgit 1.4.1