about summary refs log tree commit diff stats
path: root/pkgs/by-name/fu/fupdate-sys/fupdate-sys.sh
diff options
context:
space:
mode:
Diffstat (limited to '')
-rwxr-xr-xpkgs/by-name/fu/fupdate-sys/fupdate-sys.sh19
1 files changed, 8 insertions, 11 deletions
diff --git a/pkgs/by-name/fu/fupdate-sys/fupdate-sys.sh b/pkgs/by-name/fu/fupdate-sys/fupdate-sys.sh
index 38debf44..28e09f3d 100755
--- a/pkgs/by-name/fu/fupdate-sys/fupdate-sys.sh
+++ b/pkgs/by-name/fu/fupdate-sys/fupdate-sys.sh
@@ -13,10 +13,12 @@ die() {
     fi
 }
 print() {
-    printf "%s" "$*"
+    # shellcheck disable=SC2059
+    printf "$*"
 }
 println() {
-    printf "%s\n" "$*"
+    # shellcheck disable=SC2059
+    printf "$*\n"
 }
 eprint() {
     >&2 print "$@"
@@ -24,7 +26,7 @@ eprint() {
 eprintln() {
     >&2 println "$@"
 }
-if [ -n "$NO_COLOR" ]; then
+if [ "${NO_COLOR-unset}" != "unset" ]; then
     error() {
         eprintln "==> ERROR:" "$*"
     }
@@ -71,7 +73,6 @@ else
 fi
 # }}}
 
-
 NAME="update-sys"
 help() {
     cat <<EOF
@@ -106,7 +107,7 @@ while [ "$#" -gt 0 ]; do
         help 0
         ;;
     "--branch" | "-b")
-        if [ -n "$2" ]; then
+        if [ "${2-unset}" != "unset" ]; then
             BRANCH="$2"
         else
             error "$1 requires an argument"
@@ -115,7 +116,7 @@ while [ "$#" -gt 0 ]; do
         shift 2
         ;;
     "--mode" | "-m")
-        if [ -n "$2" ]; then
+        if [ "${2-unset}" != "unset" ]; then
             MODE="$2"
         else
             error "$1 requires an argument"
@@ -149,11 +150,7 @@ trap cleanup EXIT
 git remote show origin | grep 'HEAD' | cut -d':' -f2 | sed -e 's/^ *//g' -e 's/ *$//g' >"$default_branch" &
 
 msg2 "Updating system..."
-if [ -n "$MODE" ]; then
-    nixos-rebuild "$MODE"
-else
-    nixos-rebuild switch
-fi
+nixos-rebuild "${MODE-switch}"
 
 git switch "$(cat "$default_branch")" >/dev/null 2>&1 && msg2 "Switched to branch '$(cat "$default_branch")'"
 msg "Finished Update!"