From 106dca20fef667ef4605528d51c2b9968731242a Mon Sep 17 00:00:00 2001 From: Benedikt Peetz Date: Sun, 23 Aug 2026 23:54:25 +0200 Subject: daemon/api: Remove `add_history` This request is a footgun, as it will leave commands that never return (e.g. `shutdown`, `exit`, etc.) unrecorded. --- crates/turtle/src/client/mod.rs | 24 ------------------------ 1 file changed, 24 deletions(-) (limited to 'crates/turtle/src/client/mod.rs') diff --git a/crates/turtle/src/client/mod.rs b/crates/turtle/src/client/mod.rs index 28289652..531d8597 100644 --- a/crates/turtle/src/client/mod.rs +++ b/crates/turtle/src/client/mod.rs @@ -7,7 +7,6 @@ use hyper_util::rt::TokioIo; use tokio::net::UnixStream; -use crate::generated::history::AddHistoryRequest; use crate::generated::{ self, DAEMON_PROTOCOL_VERSION, control::{ @@ -235,29 +234,6 @@ impl HistoryClient { Ok(self.client.end_history(req).await?.into_inner()) } - pub async fn add_history( - &mut self, - h: History, - duration: std::time::Duration, - exit: i64, - ) -> Result { - let req = AddHistoryRequest { - start: Some(StartHistoryRequest { - timestamp: time_to_proto_timestamp(h.timestamp), - command: h.command, - cwd: h.cwd, - session: h.session, - hostname: h.hostname, - author: h.author, - intent: h.intent, - }), - exit, - duration: std_to_proto_duration(duration), - }; - - Ok(self.client.add_history(req).await?.into_inner()) - } - pub async fn history(&mut self, range: Option) -> Result> { let req = HistoryRequest { range: range.map(|r| generated::history::Range { -- cgit v1.3.1