From 0f381dd5152e60bf5473955e9a503a466e50219f Mon Sep 17 00:00:00 2001 From: Ellie Huxtable Date: Thu, 24 Jul 2025 10:08:20 +0200 Subject: fix: use transaction for idx consistency checking (#2840) --- crates/atuin-server-postgres/src/lib.rs | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) (limited to 'crates/atuin-server-postgres/src') diff --git a/crates/atuin-server-postgres/src/lib.rs b/crates/atuin-server-postgres/src/lib.rs index 65e8efbf..f399945e 100644 --- a/crates/atuin-server-postgres/src/lib.rs +++ b/crates/atuin-server-postgres/src/lib.rs @@ -620,9 +620,12 @@ impl Database for Postgres { const STATUS_SQL: &str = "select host, tag, max(idx) from store where user_id = $1 group by host, tag"; + // Use a transaction to ensure consistent reads from both tables + let mut tx = self.pool.begin().await.map_err(fix_error)?; + let mut res: Vec<(Uuid, String, i64)> = sqlx::query_as(STATUS_SQL) .bind(user.id) - .fetch_all(&self.pool) + .fetch_all(&mut *tx) .await .map_err(fix_error)?; res.sort(); @@ -636,11 +639,13 @@ impl Database for Postgres { let mut cached_res: Vec<(Uuid, String, i64)> = sqlx::query_as("select host, tag, idx from store_idx_cache where user_id = $1") .bind(user.id) - .fetch_all(&self.pool) + .fetch_all(&mut *tx) .await .map_err(fix_error)?; cached_res.sort(); + tx.commit().await.map_err(fix_error)?; + let mut status = RecordStatus::new(); let equal = res == cached_res; -- cgit v1.3.1