From 79622cf698a1c831341f6e3906005ddbb54c55d8 Mon Sep 17 00:00:00 2001 From: Ellie Huxtable Date: Fri, 24 Mar 2023 09:04:57 +0000 Subject: Delete all instances of a command (#797) * Delete all instances of a command Our search command will de-dupe results by default. But... This isn't great for deleting! You don't want to run it over-and-over-and-over until all commands are deleted. Loop the query, and keep on deleting what it returns until they are all gone. * Optimize delete upload It was running a request for every element, on every sync lol Only push a delete if needed Future: push all deletes in one request --- atuin-client/src/database.rs | 1 + 1 file changed, 1 insertion(+) (limited to 'atuin-client/src/database.rs') diff --git a/atuin-client/src/database.rs b/atuin-client/src/database.rs index 4135646c..bb4d9dfa 100644 --- a/atuin-client/src/database.rs +++ b/atuin-client/src/database.rs @@ -460,6 +460,7 @@ impl Database for Sqlite { ]) .group_by("command") .group_by("exit") + .and_where("deleted_at is null") .order_desc("timestamp"); let query = query.sql().expect("bug in list query. please report"); -- cgit v1.3.1