From 9fa223eaaf0eda4e5f76621dc6d457417afb8b54 Mon Sep 17 00:00:00 2001 From: Remo Senekowitsch Date: Wed, 12 Jun 2024 17:45:38 +0200 Subject: chore(build): compile protobufs with protox (#2122) * chore(build): compile protobufs with protox protox is a pure-rust implementation of the protobuf compiler. Therefore, it can be managed by cargo. This removes the implicit dependency on protoc being available in the environment for the build. * fix(build): replace copypasta in build script The paths passed to `compile` aren't actually used by the build. `skip_protoc_run` prevents that. That's why a clean build succeeds even with this mistake. However, the paths are passed to a `cargo:rerun-if-changed` directive. So this mistake would've caused a failed incremental build if the protobuf definitions were changed. --- .github/workflows/rust.yml | 30 ------------------------------ 1 file changed, 30 deletions(-) (limited to '.github/workflows') diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 6e734c99..0f4734a0 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -24,11 +24,6 @@ jobs: with: toolchain: stable - - name: Install Protoc - uses: arduino/setup-protoc@v3 - with: - repo-token: ${{ secrets.GITHUB_TOKEN }} - - uses: actions/cache@v3 with: path: | @@ -65,11 +60,6 @@ jobs: with: tool: cross - - name: Install Protoc - uses: arduino/setup-protoc@v3 - with: - repo-token: ${{ secrets.GITHUB_TOKEN }} - - uses: actions/cache@v3 with: path: | @@ -105,11 +95,6 @@ jobs: with: toolchain: stable - - name: Install Protoc - uses: arduino/setup-protoc@v3 - with: - repo-token: ${{ secrets.GITHUB_TOKEN }} - - uses: taiki-e/install-action@v2 name: Install nextest with: @@ -140,11 +125,6 @@ jobs: with: toolchain: stable - - name: Install Protoc - uses: arduino/setup-protoc@v3 - with: - repo-token: ${{ secrets.GITHUB_TOKEN }} - - uses: actions/cache@v3 with: path: | @@ -189,11 +169,6 @@ jobs: with: toolchain: stable - - name: Install Protoc - uses: arduino/setup-protoc@v3 - with: - repo-token: ${{ secrets.GITHUB_TOKEN }} - - uses: taiki-e/install-action@v2 name: Install nextest with: @@ -224,11 +199,6 @@ jobs: toolchain: stable components: clippy - - name: Install Protoc - uses: arduino/setup-protoc@v3 - with: - repo-token: ${{ secrets.GITHUB_TOKEN }} - - uses: actions/cache@v3 with: path: | -- cgit v1.3.1