diff options
| author | Benedikt Peetz <benedikt.peetz@b-peetz.de> | 2026-08-23 23:54:25 +0200 |
|---|---|---|
| committer | Benedikt Peetz <benedikt.peetz@b-peetz.de> | 2026-08-23 23:54:25 +0200 |
| commit | 106dca20fef667ef4605528d51c2b9968731242a (patch) | |
| tree | 2c422d17434311022dc52ea2d98f1245b9af560d /crates/daemon/src/api | |
| parent | Cargo.toml: 20.0.0 -> 20.0.1 (diff) | |
| download | atuin-106dca20fef667ef4605528d51c2b9968731242a.zip | |
daemon/api: Remove `add_history`
This request is a footgun, as it will leave commands that never return
(e.g. `shutdown`, `exit`, etc.) unrecorded.
Diffstat (limited to '')
| -rw-r--r-- | crates/daemon/src/api/history.rs | 32 |
1 files changed, 3 insertions, 29 deletions
diff --git a/crates/daemon/src/api/history.rs b/crates/daemon/src/api/history.rs index 2229e5b1..afd823b1 100644 --- a/crates/daemon/src/api/history.rs +++ b/crates/daemon/src/api/history.rs @@ -4,7 +4,7 @@ use dashmap::DashMap; use eyre::Result; use time::OffsetDateTime; use tokio_stream::Stream; -use tonic::{IntoRequest, Request, Response, Status}; +use tonic::{Request, Response, Status}; use tracing::{Level, instrument}; use crate::{ @@ -20,8 +20,8 @@ use turtle_api::{ generated::{ DAEMON_PROTOCOL_VERSION, history::{ - AddHistoryRequest, EndHistoryReply, EndHistoryRequest, HistoryEntry, HistoryEventKind, - HistoryReply, HistoryRequest, StartHistoryReply, StartHistoryRequest, TailHistoryReply, + EndHistoryReply, EndHistoryRequest, HistoryEntry, HistoryEventKind, HistoryReply, + HistoryRequest, StartHistoryReply, StartHistoryRequest, TailHistoryReply, TailHistoryRequest, history_server::{History as HistorySvc, HistoryServer}, }, @@ -105,32 +105,6 @@ impl HistorySvc for HistoryService { } #[instrument(skip_all, level = Level::INFO)] - async fn add_history( - &self, - request: Request<AddHistoryRequest>, - ) -> Result<Response<EndHistoryReply>, Status> { - let req = request.into_inner(); - let start_req = req.start.expect("is some"); - - let start_response = self - .start_history(start_req.into_request()) - .await? - .into_inner(); - let end_responnse = self - .end_history( - EndHistoryRequest { - id: start_response.id, - exit: req.exit, - duration: req.duration, - } - .into_request(), - ) - .await?; - - Ok(end_responnse) - } - - #[instrument(skip_all, level = Level::INFO)] async fn start_history( &self, request: Request<StartHistoryRequest>, |
