diff options
| author | Eric Crosson <EricCrosson@users.noreply.github.com> | 2025-09-09 21:35:41 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-09-09 19:35:41 -0700 |
| commit | be3f283a54ccec833e4d33860d045ed483b628bb (patch) | |
| tree | ca6fd947c33891f681f009c3fdc8b1be291879c2 | |
| parent | fix: use fullscreen if `inline_height` is too large (#2888) (diff) | |
| download | atuin-be3f283a54ccec833e4d33860d045ed483b628bb.zip | |
build: remove legacy Apple SDK frameworks (#2885)
Thanks for your work on atuin! I've loved using it over the past year.
According to nixos.org[^1], the `darwin.apple_sdk` frameworks have been stubs for some time, and are now removed. Evaluating `atuin` on darwin on `nixpkgs-unstable` results in the following evaluation error:
```
error: darwin.apple_sdk_11_0 has been
removed as it was a legacy compatibility stub; see
<https://nixos.org/manual/nixpkgs/stable/#sec-darwin-legacy-frameworks>
for migration instructions
```
According to those linked docs, the fix is to remove references to these SDKs, which will not have any other effect since they were stubs anyway.
[^1]: https://nixos.org/manual/nixpkgs/stable/#sec-darwin-legacy-frameworks
<!-- Thank you for making a PR! Bug fixes are always welcome, but if you're adding a new feature or changing an existing one, we'd really appreciate if you open an issue, post on the forum, or drop in on Discord -->
## Checks
- [x] I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
- [x] I have checked that there are no existing pull requests for the same thing
Diffstat (limited to '')
| -rw-r--r-- | atuin.nix | 5 | ||||
| -rw-r--r-- | flake.nix | 1 |
2 files changed, 1 insertions, 5 deletions
@@ -10,9 +10,6 @@ installShellFiles, rustPlatform, libiconv, - Security, - SystemConfiguration, - AppKit, }: rustPlatform.buildRustPackage { name = "atuin"; @@ -27,7 +24,7 @@ rustPlatform.buildRustPackage { nativeBuildInputs = [installShellFiles]; - buildInputs = lib.optionals stdenv.isDarwin [libiconv Security SystemConfiguration AppKit]; + buildInputs = lib.optionals stdenv.isDarwin [libiconv]; postInstall = '' installShellCompletion --cmd atuin \ @@ -25,7 +25,6 @@ in { packages.atuin = pkgs.callPackage ./atuin.nix { - inherit (pkgs.darwin.apple_sdk.frameworks) Security SystemConfiguration AppKit; rustPlatform = let toolchain = |
