diff options
| author | Remo Senekowitsch <remo@buenzli.dev> | 2024-06-12 17:45:38 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-06-12 16:45:38 +0100 |
| commit | 9fa223eaaf0eda4e5f76621dc6d457417afb8b54 (patch) | |
| tree | 8327137d550f5aacdd6c05bc89eed3afca3387dd /.github/workflows/rust.yml | |
| parent | chore: remove unnecessary proto import (#2120) (diff) | |
| download | atuin-9fa223eaaf0eda4e5f76621dc6d457417afb8b54.zip | |
chore(build): compile protobufs with protox (#2122)
* chore(build): compile protobufs with protox
protox is a pure-rust implementation of the protobuf compiler.
Therefore, it can be managed by cargo.
This removes the implicit dependency on protoc being available
in the environment for the build.
* fix(build): replace copypasta in build script
The paths passed to `compile` aren't actually used by the build.
`skip_protoc_run` prevents that.
That's why a clean build succeeds even with this mistake.
However, the paths are passed to a `cargo:rerun-if-changed` directive.
So this mistake would've caused a failed incremental build if the
protobuf definitions were changed.
Diffstat (limited to '')
| -rw-r--r-- | .github/workflows/rust.yml | 30 |
1 files changed, 0 insertions, 30 deletions
diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 6e734c99..0f4734a0 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -24,11 +24,6 @@ jobs: with: toolchain: stable - - name: Install Protoc - uses: arduino/setup-protoc@v3 - with: - repo-token: ${{ secrets.GITHUB_TOKEN }} - - uses: actions/cache@v3 with: path: | @@ -65,11 +60,6 @@ jobs: with: tool: cross - - name: Install Protoc - uses: arduino/setup-protoc@v3 - with: - repo-token: ${{ secrets.GITHUB_TOKEN }} - - uses: actions/cache@v3 with: path: | @@ -105,11 +95,6 @@ jobs: with: toolchain: stable - - name: Install Protoc - uses: arduino/setup-protoc@v3 - with: - repo-token: ${{ secrets.GITHUB_TOKEN }} - - uses: taiki-e/install-action@v2 name: Install nextest with: @@ -140,11 +125,6 @@ jobs: with: toolchain: stable - - name: Install Protoc - uses: arduino/setup-protoc@v3 - with: - repo-token: ${{ secrets.GITHUB_TOKEN }} - - uses: actions/cache@v3 with: path: | @@ -189,11 +169,6 @@ jobs: with: toolchain: stable - - name: Install Protoc - uses: arduino/setup-protoc@v3 - with: - repo-token: ${{ secrets.GITHUB_TOKEN }} - - uses: taiki-e/install-action@v2 name: Install nextest with: @@ -224,11 +199,6 @@ jobs: toolchain: stable components: clippy - - name: Install Protoc - uses: arduino/setup-protoc@v3 - with: - repo-token: ${{ secrets.GITHUB_TOKEN }} - - uses: actions/cache@v3 with: path: | |