aboutsummaryrefslogtreecommitdiffstats
path: root/crates
diff options
context:
space:
mode:
authorBenedikt Peetz <benedikt.peetz@b-peetz.de>2025-02-21 22:32:54 +0100
committerBenedikt Peetz <benedikt.peetz@b-peetz.de>2025-02-21 22:32:54 +0100
commitb1474f9dc8dc1ed22c2a78680e40bd315cb82b0f (patch)
treedd07f07483f13d0479075bfd15346a70c5041698 /crates
parentfix(yt/storage/notify): Switch from a polling based system to inotify (diff)
downloadyt-b1474f9dc8dc1ed22c2a78680e40bd315cb82b0f.zip
chore(crates/libmpv2): Make `cargo clippy` happy
Diffstat (limited to '')
-rw-r--r--crates/libmpv2/src/mpv.rs9
-rw-r--r--crates/libmpv2/src/mpv/events.rs2
-rw-r--r--crates/libmpv2/src/mpv/protocol.rs6
3 files changed, 8 insertions, 9 deletions
diff --git a/crates/libmpv2/src/mpv.rs b/crates/libmpv2/src/mpv.rs
index 7ac1b43..82d02ed 100644
--- a/crates/libmpv2/src/mpv.rs
+++ b/crates/libmpv2/src/mpv.rs
@@ -375,14 +375,14 @@ unsafe impl SetData for String {
/// Wrapper around an `&str` returned by mpv, that properly deallocates it with mpv's allocator.
#[derive(Debug, Hash, Eq, PartialEq)]
pub struct MpvStr<'a>(&'a str);
-impl<'a> Deref for MpvStr<'a> {
+impl Deref for MpvStr<'_> {
type Target = str;
fn deref(&self) -> &str {
self.0
}
}
-impl<'a> Drop for MpvStr<'a> {
+impl Drop for MpvStr<'_> {
fn drop(&mut self) {
unsafe { libmpv2_sys::mpv_free(self.0.as_ptr() as *mut u8 as _) };
}
@@ -403,7 +403,7 @@ unsafe impl<'a> GetData for MpvStr<'a> {
}
}
-unsafe impl<'a> SetData for &'a str {
+unsafe impl SetData for &str {
fn call_as_c_void<T, F: FnMut(*mut ctype::c_void) -> Result<T>>(self, mut fun: F) -> Result<T> {
let string = CString::new(self)?;
fun((&mut string.as_ptr()) as *mut *const ctype::c_char as *mut _)
@@ -511,9 +511,8 @@ impl Mpv {
}
initializer(MpvInitializer { ctx })?;
- mpv_err((), unsafe { libmpv2_sys::mpv_initialize(ctx) }).map_err(|err| {
+ mpv_err((), unsafe { libmpv2_sys::mpv_initialize(ctx) }).inspect_err(|_| {
unsafe { libmpv2_sys::mpv_terminate_destroy(ctx) };
- err
})?;
let ctx = unsafe { NonNull::new_unchecked(ctx) };
diff --git a/crates/libmpv2/src/mpv/events.rs b/crates/libmpv2/src/mpv/events.rs
index ea105d4..e27da2c 100644
--- a/crates/libmpv2/src/mpv/events.rs
+++ b/crates/libmpv2/src/mpv/events.rs
@@ -86,7 +86,7 @@ impl<'a> PropertyData<'a> {
mpv_format::Node => {
let sys_node = *(ptr as *mut libmpv2_sys::mpv_node);
let node = SysMpvNode::new(sys_node, false);
- return Ok(PropertyData::Node(node.value().unwrap()));
+ Ok(PropertyData::Node(node.value().unwrap()))
}
mpv_format::None => unreachable!(),
_ => unimplemented!(),
diff --git a/crates/libmpv2/src/mpv/protocol.rs b/crates/libmpv2/src/mpv/protocol.rs
index c4f0e2f..ec840d8 100644
--- a/crates/libmpv2/src/mpv/protocol.rs
+++ b/crates/libmpv2/src/mpv/protocol.rs
@@ -101,7 +101,7 @@ where
let slice = slice::from_raw_parts_mut(buf, nbytes as _);
((*data).read_fn)(&mut *(*data).cookie, slice)
});
- if let Ok(ret) = ret { ret } else { -1 }
+ ret.unwrap_or(-1)
}
unsafe extern "C" fn seek_wrapper<T, U>(cookie: *mut ctype::c_void, offset: i64) -> i64
@@ -173,8 +173,8 @@ pub struct ProtocolContext<'parent, T: RefUnwindSafe, U: RefUnwindSafe> {
_does_not_outlive: PhantomData<&'parent Mpv>,
}
-unsafe impl<'parent, T: RefUnwindSafe, U: RefUnwindSafe> Send for ProtocolContext<'parent, T, U> {}
-unsafe impl<'parent, T: RefUnwindSafe, U: RefUnwindSafe> Sync for ProtocolContext<'parent, T, U> {}
+unsafe impl<T: RefUnwindSafe, U: RefUnwindSafe> Send for ProtocolContext<'_, T, U> {}
+unsafe impl<T: RefUnwindSafe, U: RefUnwindSafe> Sync for ProtocolContext<'_, T, U> {}
impl<'parent, T: RefUnwindSafe, U: RefUnwindSafe> ProtocolContext<'parent, T, U> {
fn new(